Skip to content

Add @Sendable to HTTP unary completion closure #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add @Sendable to HTTP unary completion closure #95

merged 1 commit into from
Jan 30, 2023

Conversation

@rebello95
Copy link
Collaborator

@rebello95 rebello95 commented Jan 30, 2023 •
edited
Loading

This prevents a warning that can be seen with strict concurrency flags when subclassing URLSessionHTTPClient.

buildbreaker
buildbreaker approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@buildbreaker buildbreaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rebello95 rebello95 merged commit 028bd7c into main Jan 30, 2023
@rebello95 rebello95 deleted the sendable-closure branch January 30, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@buildbreaker buildbreaker buildbreaker approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rebello95 @buildbreaker