Skip to content

Add @Sendable to HTTP unary completion closure #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Add @Sendable to HTTP unary completion closure #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Libraries/Connect/Implementation/URLSessionHTTPClient.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ open class URLSessionHTTPClient: NSObject, HTTPClientInterface {

@discardableResult
open func unary(
request: HTTPRequest, completion: @escaping (HTTPResponse) -> Void
request: HTTPRequest, completion: @Sendable @escaping (HTTPResponse) -> Void
) -> Cancelable {
let urlRequest = URLRequest(httpRequest: request)
let task = self.session.dataTask(with: urlRequest) { data, urlResponse, error in
Expand Down
3 changes: 2 additions & 1 deletion Libraries/Connect/Interfaces/HTTPClientInterface.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ public protocol HTTPClientInterface {
///
/// - returns: A type which can be used to cancel the outbound request.
@discardableResult
func unary(request: HTTPRequest, completion: @escaping (HTTPResponse) -> Void) -> Cancelable
func unary(request: HTTPRequest, completion: @Sendable @escaping (HTTPResponse) -> Void)
-> Cancelable

/// Initialize a new HTTP stream.
///
Expand Down