Auction

[viken33]

The Problem

Auction MVP
Specs

The Solution

This PR is a check-in send to see if we are on the right track and if changes on different modules/files are according to MVP design. Its on auction branch on https://github.com/1Hive/vector.git

Update:
Added an Auction Stack to vector in order to test multi router / auction flow
Basic functionality working, can be tested from server-node RPC but in order to run an auction:
- All channels must be setup first. This is basically because actual method in fee service from router takes the channels as params. A different method is needed to calculate fees based only on PUBIDs (lookup channels, calculate deployment fees, etc). Hence, if channels are not present router throws an error and doesn't respond to auction message.
- Auction must be in the same chain, otherwise routers throw an error about not being able to calculate swapRates/AMM rates. Not sure why.

Main additions:
Start-auction script to deploy 3 routers
3 different router.config files to have different fee rates
Makerfile changes ( make start-auction )

[viken33]

added some comments

[rhlsthrm]

This looks AMAZING @viken33 ! A couple missing things:

• Add auction method to https://github.com/connext/vector/blob/main/modules/types/src/node.ts#L14.
• The above will create build errors where the appropriate methods need to be added in the REST client and the browser node.

[rhlsthrm]

This looks great, thanks for addressing all the changes!

A couple of final things we need:

• Unit tests
• Feature flag. We need to add a config item so that we can merge this into our prod branch and disable the feature until we fully test it.

[viken33]

Added unit tests where I found them to be relevant for auction (rpc method on engine, listener on router).
If there are more tests we should add, please point me to the tests specs files or folders and I'll them 👍

[rhlsthrm]

Doesn't this have to get set before you send the auction message? I'm not sure if this set of code is being hit. You might need to return a promise that resolves within this message, since I believe this is the last thing that should happen.