Skip to content

fix: remove obsolete service account #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DenisBiondic merged 1 commit into from
Nov 11, 2019
Merged

fix: remove obsolete service account #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Models/K8sRoleBinding.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ public static K8sRoleBinding NamespaceFullAccess(string namespacename, string[]
};

var subjects = users.ToList().Select(user => { return new K8sUserSubjectItem(user, "rbac.authorization.k8s.io"); }).ToList<K8sSubjectBaseItem>();
subjects.Add(new K8sServiceAccountSubjectItem("default", namespacename));
roleBinding.Subjects = subjects.ToArray();

return roleBinding;
Expand Down
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@

This is the Kubernetes Controller implementation for Conplement CoreOps specific Kubernetes extensions. Can be seen as a backend to the companion project [copsctl](https://github.com/conplementAG/copsctl)


This project is "based" on [metacontroller](https://github.com/GoogleCloudPlatform/metacontroller) and written in C#, mainly for three reasons:

- Metacontroller is the simplest custom controller approach in Kubernetes, and offers easy parent / child resource tracking
Expand All @@ -15,7 +14,7 @@ This project is "based" on [metacontroller](https://github.com/GoogleCloudPlatfo

## Setup

tbd after first release
Check the instructions on the [release page](https://github.com/conplementAG/cops-controller/releases).

## Development

Expand All @@ -27,6 +26,8 @@ For developing, we use Visual Studio Code and Azure Dev Spaces (running inside o

`az aks use-dev-spaces -g ... -n ... --space space_name`

If the command above fails (like to linux), then you can use the `azds controller create -tn ... -n ... -g ...` command instead.

Install the Azure DevSpaces CLI and run:
`azds space select --name your_space_name`

Expand Down