Added support for Layer Package (lpk) imports #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikmolnar
requested changes
Jul 26, 2018
Contributor
nikmolnar
left a comment
nikmolnar
left a comment
There was a problem hiding this comment.
This looks great, nice work! Please add a test for this new method. You can use the test for import_netcdf for guidance. Otherwise, just a few minor cleanup items.
See: https://github.com/consbio/python-databasin/blob/master/tests/test_client.py#L153
databasin/client.py
Outdated
| raise | ||
|
|
||
| def create_job(self, name, job_args={}, block=False): | ||
| #MG self.build_url(JOB_CREATE_PATH) = https://databasin.org/api/v1/jobs/ |
Contributor
There was a problem hiding this comment.
Please delete this line.
databasin/client.py
Outdated
|
|
||
| def import_lpk(self, lpk_file): | ||
| if lpk_file.endswith('.lpk'): | ||
| f = open(lpk_file, 'a+b') |
Contributor
There was a problem hiding this comment.
Since this isn't written to, it should be opened in read-only:
f = open(lpk_file, 'rb')
databasin/client.py
Outdated
| else: | ||
| raise ValueError('File must be an ArcGIS Layer Package with a .lpk extension') | ||
|
|
||
| filename = '{0}.lpk'.format(os.path.splitext(os.path.basename(lpk_file))[0]) |
Contributor
There was a problem hiding this comment.
If lpk_file already ends with .lpk (as enforced on L155), why not just grab the basename?
filename = os.path.basename(lpk_file)
databasin/client.py
Outdated
| 'dataset_type': 'ArcGIS_Native' | ||
| } | ||
|
|
||
| tmp_job = self.create_job('create_import_job', job_args=tmp_job_args, block=True) |
Contributor
There was a problem hiding this comment.
tmp_job is a misnomer. It's really an "import" job, but simply job would be fine, too.
nikmolnar
approved these changes
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.