Conversation
karlem
force-pushed
the
parent-contracts-deployment
branch
from
52043da to
5a5941b
Compare
| use clap::{Args, ValueEnum}; | ||
| use ethers::types::Address; | ||
| use fendermint_eth_deployer::{EthContractDeployer, SubnetCreationPrivilege}; | ||
| use fendermint_eth_hardhat::Hardhat; |
Contributor
There was a problem hiding this comment.
will it create some kind of cycler dependency in the future?
Contributor
Author
There was a problem hiding this comment.
Good question. I thought about it quite a bit and I wasn't sure where exactly to put it. Also didn't want to re-shuffle too much. I honestly think that moving forward we should have some crates that are outside of ipc and fendermint and can be used by both. WDYT?
cryptoAtwill
approved these changes
Mar 25, 2025
Co-authored-by: LePremierHomme <57456510+LePremierHomme@users.noreply.github.com>
cryptoAtwill
added a commit
that referenced
this pull request
Apr 1, 2025
Co-authored-by: cryptoAtwill <108330426+cryptoAtwill@users.noreply.github.com> Co-authored-by: LePremierHomme <57456510+LePremierHomme@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #1316
This PR allows deploying contracts to the L1 parent network from
IPC. This is the first version. Future PRs should address the following:This change is