fix: check for success in kill and releaseStake#1326
Closed
avichalp wants to merge 1 commit intoconsensus-shipyard:mainfrom
Closed
fix: check for success in kill and releaseStake#1326avichalp wants to merge 1 commit intoconsensus-shipyard:mainfrom
kill and releaseStake#1326avichalp wants to merge 1 commit intoconsensus-shipyard:mainfrom
Conversation
cryptoAtwill
approved these changes
Apr 10, 2025
Author
|
@cryptoAtwill: any clue why the e2e tests are failing? it seems to be unrelated |
Signed-off-by: avichalp <hi@avichalp.me>
drahnr
force-pushed
the
avichalp/fix-S303
branch
from
b965b3b to
9968a25
Compare
Contributor
|
A git dependency of a transient node js dependency disappeared, fixed in main. The rebase should take care of it. |
Contributor
|
Closing, already fixed here: #1351 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request aim to fix the security issue described here: https://github.com/consensus-shipyard/ipc-recall-audit-1/issues/50
It introduces a new error type and updates the handling of fund transfers in the
GatewayManagerFacetcontract to ensure proper error handling. The most important changes include adding the newTransferFailederror and modifying the fund transfer logic to check for success and revert if the transfer fails.This change is