Conversation
karlem
reviewed
Apr 2, 2025
Contributor
karlem
left a comment
karlem
left a comment
There was a problem hiding this comment.
@drahnr Given the modify_exec_state is only used at one place, can't we just get rid of it entirely?
Reviewable status: 0 of 2 files reviewed, all discussions resolved
drahnr
force-pushed
the
bernhard-catch-unwind-fun
branch
from
9bcb739 to
ddc3586
Compare
Contributor
Author
|
@karlem technically yes, but since this already solves it, we can revisit at a later point in time |
drahnr
force-pushed
the
bernhard-catch-unwind-fun
branch
from
ddc3586 to
4b21260
Compare
drahnr
force-pushed
the
bernhard-catch-unwind-fun
branch
from
4b21260 to
241c408
Compare
karlem
approved these changes
Jun 2, 2025
drahnr
force-pushed
the
bernhard-catch-unwind-fun
branch
from
79658d5 to
e6d545f
Compare
drahnr
force-pushed
the
bernhard-catch-unwind-fun
branch
from
e6d545f to
2be487d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids take and put of state
This change is