Conversation
karlem
reviewed
May 19, 2025
karlem
reviewed
May 20, 2025
karlem
requested changes
May 20, 2025
Contributor
karlem
left a comment
karlem
left a comment
There was a problem hiding this comment.
It would be good to write simple tests for both functions and besides of the comments I left we could also:
- Emit an event when the genesis amount increases or decreases (not mandatory)
- Decides whether we want to remove the validator from list if the weight is 0?
Both are not mandatory.
karlem
approved these changes
Jun 2, 2025
karlem
reviewed
Jun 2, 2025
cryptoAtwill
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is