Merged
Conversation
drahnr
approved these changes
Apr 25, 2025
Contributor
LePremierHomme
left a comment
LePremierHomme
left a comment
There was a problem hiding this comment.
Why remove it instead of using it?
Contributor
Author
|
@LePremierHomme I think the protocol does not have garbage collection at the moment. We can add it back later when GC is included, but for now, removing just keeping the code base clean. |
LePremierHomme
approved these changes
May 12, 2025
Contributor
|
@cryptoAtwill please create an issue to re-introduce / revert his commit once garbage collection is implmented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is reported that
pruneBottomUpCheckpointsis never used, removing it.