Conversation
karlem
reviewed
May 19, 2025
karlem
reviewed
May 19, 2025
karlem
requested changes
May 19, 2025
Contributor
karlem
left a comment
There was a problem hiding this comment.
Looks good. Just small details.
karlem
approved these changes
May 20, 2025
Contributor
|
@cryptoAtwill I have approved but I think you need to update the e2e tests. Given the error message below it seems related to your fix. |
Contributor
Author
added 3 commits
June 12, 2025 22:34
Contributor
|
Aiming to merge tomorrow. |
Contributor
|
Do we need a deployment documentation update when merging this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding owner approve for subnet register. This means a subnet can be registered in the gateway only if the owner approves it.