Skip to content

fix(dashboard): close 2 strong slop-scan findings + adversarial-review hardening #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kaicianflone merged 1 commit into from
May 6, 2026
Merged

fix(dashboard): close 2 strong slop-scan findings + adversarial-review hardening #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions apps/dashboard/src/components/agents/AgentsPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,6 @@ export function AgentsPanel({ boardId, workflowNodes = [] }: AgentsPanelProps) {
const [editDraft, setEditDraft] = useState<Record<string, any>>({});
const [apiError, setApiError] = useState<string | null>(null);

function parseMetadata(p: any): Record<string, any> {
return parseAgentMetadata(p);
}

async function refresh() {
setApiError(null);
try {
Expand Down Expand Up @@ -148,7 +144,7 @@ export function AgentsPanel({ boardId, workflowNodes = [] }: AgentsPanelProps) {
}

function startEdit(p: any) {
const meta = parseMetadata(p);
const meta = parseAgentMetadata(p);
setEditingParticipant(p.id);
setEditDraft({
weight: p.weight,
Expand Down Expand Up @@ -234,7 +230,6 @@ export function AgentsPanel({ boardId, workflowNodes = [] }: AgentsPanelProps) {
saveEdit={saveEdit}
startEdit={startEdit}
setEditingParticipant={setEditingParticipant}
parseMetadata={parseMetadata}
onDelete={handleDeleteParticipant}
/>
))}
Expand All @@ -255,7 +250,6 @@ export function AgentsPanel({ boardId, workflowNodes = [] }: AgentsPanelProps) {
saveEdit={saveEdit}
startEdit={startEdit}
setEditingParticipant={setEditingParticipant}
parseMetadata={parseMetadata}
onDelete={handleDeleteParticipant}
/>
))}
Expand Down Expand Up @@ -406,8 +400,8 @@ export function AgentsPanel({ boardId, workflowNodes = [] }: AgentsPanelProps) {
);
}

function ParticipantCard({ p, editingParticipant, editDraft, setEditDraft, saveEdit, startEdit, setEditingParticipant, parseMetadata, onDelete }: any) {
const meta = parseMetadata(p);
function ParticipantCard({ p, editingParticipant, editDraft, setEditDraft, saveEdit, startEdit, setEditingParticipant, onDelete }: any) {
const meta = parseAgentMetadata(p);
const isInternal = meta.agentType === 'internal';
const isExternal = meta.agentType === 'external';
const isAgent = p.subject_type === 'agent';
Expand Down Expand Up @@ -501,7 +495,7 @@ function ParticipantCard({ p, editingParticipant, editDraft, setEditDraft, saveE
<Globe className="h-2.5 w-2.5" /> API
</Badge>
)}
{meta.chatAdapter && (
{typeof meta.chatAdapter === 'string' && meta.chatAdapter && (
<Badge variant="secondary" className="text-[9px] px-1 py-0 h-4 gap-0.5">
<MessageSquare className="h-2.5 w-2.5" /> {meta.chatAdapter}
</Badge>
Expand Down
6 changes: 6 additions & 0 deletions apps/dashboard/src/pages/WorkflowsDashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ export default function WorkflowsDashboard() {
}

async function handleLoadTemplate(templateId: string) {
setApiError(null);
try {
const result = await getTemplate(templateId);
if (result?.template) {
Expand All @@ -351,9 +352,14 @@ export default function WorkflowsDashboard() {
setNodes(result.template.definition?.nodes || []);
setRuns([]);
setSelectedId(null);
} else {
// 200 OK with empty/null template — surface so we don't silently swallow
// backend regressions or proxy-mangled responses (Codex adversarial finding).
setApiError('Failed to load template: server returned no template payload');
}
} catch (error) {
console.error('Failed to load template:', error);
setApiError('Failed to load template: ' + (error instanceof Error ? error.message : String(error)));
}
}

Expand Down
Loading