refactor: Move message types from standard to own module#14
Merged
Conversation
jbeyerstedt
force-pushed
the
refactor/split-standards
branch
from
78b1e38 to
b7f28ab
Compare
BendixBuchheister
previously approved these changes
Apr 20, 2026
BendixBuchheister
left a comment
BendixBuchheister
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, but you need to resolve the merge conflicts first
jbeyerstedt
force-pushed
the
refactor/split-standards
branch
from
b7f28ab to
5468a05
Compare
Collaborator
Author
|
you were 10 seconds to early |
BendixBuchheister
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the
lib.rsis quite crammed and long because it also contains all data type definitions from the ETSI and IEEE standards. I would like to move them out to their own files.As currently proposed, the API won't change because the
lib.rsis using a wildcardpub usestatement. I would like to change this, but it's probably better to combine that breaking change with the other breaking changes regarding theBitVecdependency proposed for the next "major" release.So for now, this is a pure refactoring and shouldn't have any effects on the users of this crate.