-
Notifications
You must be signed in to change notification settings - Fork 123
Removed incorrect typehint of $data in Api::api() which caused setWatchers to throw a warning #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -46,7 +46,7 @@ public function __construct() | |
| * | ||
| * @param string $method Request method. | ||
| * @param string $url URL. | ||
| * @param array $data Request data. | ||
| * @param array|string $data Request data. | ||
| * @param string $endpoint Endpoint. | ||
| * @param AuthenticationInterface $credential Credential. | ||
| * @param boolean $is_file This is a file upload request. | ||
|
|
@@ -57,6 +57,7 @@ public function __construct() | |
| * @throws Exception When request failed due CURL error. | ||
| * @throws UnauthorizedException When request failed, because user can't be authorized properly. | ||
| * @throws Exception When there was empty response instead of needed data. | ||
| * @throws \InvalidArgumentException When data is not an array and http method is GET. | ||
| */ | ||
| public function sendRequest( | ||
| $method, | ||
|
|
@@ -75,6 +76,10 @@ public function sendRequest( | |
|
|
||
| if ( $method == 'GET' ) { | ||
| $url .= '?' . http_build_query($data); | ||
|
|
||
| if ( !is_array($data) ) { | ||
| throw new \InvalidArgumentException('Data must be an array.'); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please mention in DocBlock via |
||
| } | ||
| } | ||
|
|
||
| curl_setopt($curl, CURLOPT_URL, $endpoint . $url); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be moved up. Otherwise you already get notice about wrong parameter usage in
http_build_querycall.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And same part in
PHPClientis still missing.