Functions to return project components, resolutions and issue types #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N-M
changed the title
| return $this->api(self::REQUEST_GET, '/rest/api/2/attachment/meta'); | ||
| } | ||
|
|
||
| /** |
Collaborator
There was a problem hiding this comment.
Isn't getAttachmentsMetaInformation already merged #101? Please remove from this diff
Collaborator
|
Cheers, and thank you for contributing |
| * | ||
| * @param string $project_key Project key. | ||
| * | ||
| * @return array|false |
Member
There was a problem hiding this comment.
In which cases the false gets returned?
I thought, that if project has no component, then I'll get empty array back. If there was an error I'll get an exception.
Member
|
@N-M , please create new branch for each PR you send. Don't send PR from Better yet close this PR and resend from new branch. This way on your next PR there won't such issues. |
Contributor
Author
|
I am closing this pull request and resending from new branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functions to return project components, resolutions and issue types