Set ignore_errors flag for HTTP requests in PHP client

CHANGELOG.md

@@ -37,6 +37,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 - The `Api::getRoles` call was always retuning an error by [@aik099].
 - Attempt to make a `DELETE` API call using `CurlClient` wasn't working by [@aik099].
 - Clearing local caches (statuses, priorities, fields and resolutions) on endpoint change by [@jpastoor].
+- Error details from failed API calls were not available back from Api::api method call by [@betterphp].
 
 ## [1.0.0] - 2014-07-27
 ### Added
@@ -59,3 +60,4 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 [@digitalkaoz]: https://github.com/digitalkaoz
 [@DerMika]: https://github.com/DerMika
 [@aik099]: https://github.com/aik099
+[@betterphp]: https://github.com/betterphp

src/Jira/Api/Client/PHPClient.php

@@ -122,6 +122,7 @@ public function sendRequest(
 			'http' => array(
 				'method' => $method,
 				'header' => implode("\r\n", $header),
+				'ignore_errors' => true,
 			),
 		);
 

tests/Jira/Api/Client/AbstractClientTestCase.php

@@ -30,16 +30,27 @@ protected function setUp()
 		$this->client = $this->createClient();
 	}
 
-	public function testGetRequest()
+	/**
+	 * @dataProvider getRequestWithKnownHttpCodeDataProvider
+	 */
+	public function testGetRequestWithKnownHttpCode($http_code)
 	{
 		$data = array('param1' => 'value1', 'param2' => 'value2');
-		$trace_result = $this->traceRequest(Api::REQUEST_GET, $data);
+		$trace_result = $this->traceRequest(Api::REQUEST_GET, array_merge(array('http_code' => $http_code), $data));
 
 		$this->assertEquals('GET', $trace_result['_SERVER']['REQUEST_METHOD']);
 		$this->assertContentType('application/json;charset=UTF-8', $trace_result);
 		$this->assertEquals($data, $trace_result['_GET']);
 	}
 
+	public function getRequestWithKnownHttpCodeDataProvider()
+	{
+		return array(
+			'http 200' => array(200),
+			'http 403' => array(403),
+		);
+	}
+
 	/**
 	 * @expectedException \InvalidArgumentException
 	 * @expectedExceptionMessage Data must be an array.