Added updateVersion, releaseVersion and findVersionByName #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix the build. I guess you're using PHP 5.5 syntax. |
jpastoor
force-pushed
the
feature/updateVersion
branch
from
e6a9eef to
04ee86b
Compare
| * @param array $params Key->Value list to update the version with. | ||
| * | ||
| * @return Result|false | ||
| */ |
There was a problem hiding this comment.
Please be consistent about { usage in method declaration. Other methods place { on next line.
I recommend forcing IDE to check for such stuff.
There was a problem hiding this comment.
In this method yes, but you've added other methods as well and they have same problem.
jpastoor
force-pushed
the
feature/updateVersion
branch
from
04ee86b to
d2e695a
Compare
| } | ||
|
|
||
| $params = array_merge( | ||
| array( |
There was a problem hiding this comment.
Double quotes are not needed in here.
|
Fixed style issues, will do a rebase before landing. |
jpastoor
force-pushed
the
feature/updateVersion
branch
from
49c017d to
6a39975
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanded a bit on the API's functionality for dealing with Project Versions.
Methods are unittested and work for the current live version of JIRA hosted.