Fixing deprecated error when uploading file attachments in PHP 5.5+

[DerMika]

Same pull request as done on jpastoor/jira-api-restclient:

On PHP 5.5 +, you get an E_DEPRECATED when trying to upload files. This PR fixes that by using a \CURLFile object to upload (see https://wiki.php.net/rfc/curl-file-upload)

[aik099]

Wrong indentation.

[DerMika]

Woops, I'll fix it

[aik099]

Is this regex for checking if given value isn't already in correct format that is created by curl_file_create function?

[DerMika]

Ok, removed all the unneeded stuff. Is this more like it?

[aik099]

Just return it, no else needed.

[aik099]

Ok, removed all the unneeded stuff. Is this more like it?

Almost.

[aik099]

In which PHP version @filename notation would stop working for curl uploads?

[DerMika]

Here is the RFC: https://wiki.php.net/rfc/curl-file-upload

they say

In 5.6, @ option will be switched off by default, but can still be enabled by explicit curl_setopt setting, such as:

and

In future versions, this capability may be removed completely.

But I don't think an actual decision is made to remove this capability yet.

[aik099]

So without your change on PHP 5.6 file upload won't work at all, right?

[DerMika]

On PHP 5.6 you can still enable the old behaviour with a curl_setopt(CURLOPT_SAFE_UPLOAD, false); but even then you get the E_DEPRECATED - which is the one that was bugging me.

[aik099]

On PHP 5.6 you can still enable the old behaviour with a curl_setopt(CURLOPT_SAFE_UPLOAD, false); but even then you get the E_DEPRECATED - which is the one that was bugging me.

You can enable it, but it's turned off by default and it means that uploads through this JIRA API client won't work anymore unless I merge your fix.

[DerMika]

Well actually it's currently already enabled by default - see https://github.com/chobie/jira-api-restclient/blob/master/src/Jira/Api/Client/CurlClient.php#L83 :

        if ($isFile) {
            if (defined('CURLOPT_SAFE_UPLOAD')) {
                curl_setopt($curl, CURLOPT_SAFE_UPLOAD, false);
            }

As I said, my PR was just to get rid of the ugly deprecated notice. And also to be future proof once this option goes away in the future.

[aik099]

Then maybe setting CURLOPT_SAFE_UPLOAD to false isn't needed anymore?

[DerMika]

I would think so, but honestly I haven't investigated if that could cause adverse effects.

[aik099]

OK. Then could you please squash and I'll merge it in.

[DerMika]

Unless I did something wrong, I believe I've squashed everything already?

[aik099]

Merging. Thanks @DerMika .

[DerMika]

You're welcome, thanks for indulging me :)