fix: pin-freshness audit normalises sub-path actions; bump setup-uv comment + codeql v4#83
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Triggered by run 25247352687 which auto-filed issue #82 with 13 stale-pin findings.
11 of 13 were a comment-shape mismatch:
astral-sh/setup-uvSHA pin commented# v8but our action-pinning policy + upstream reality is patch-tag (# v8.0.0) — fixed by updating the comment.2 of 13 were a real bug in
check_pin_freshness.py: it built API URLs from the full action path including sub-paths (github/codeql-action/init), 404-ing every sub-path action as a false positive. Fixed by adding_action_repo()to normalise toowner/repobefore the API call. Also bumpedgithub/codeql-action/{init,analyze}v3 -> v4.4 new regression tests; local audit now reports 0 findings on 68 pins. Issue #82 closeable when the next audit run is clean. Worth porting upstream — same bug exists in Teller's script but doesn't fire there.