docs: add table_provision to membership types references#86
Merged
pyramation merged 1 commit intomainfrom Apr 17, 2026
Merged
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Docs-only update to reflect the new
table_provisionfield onentity_type_provision/BlueprintMembershipType(shipped in constructive-db#824 and constructive#988).Three files touched, all under
.agents/skills/:constructive-membership-types/references/blueprint-membership-types.md— addstable_provisionto the field table, plus a new "Entity-Table Policies" section with a decision matrix, the 5 default policies, the override object shape, a "When to use which" cheatsheet, and a worked example.constructive-membership-types/references/orm-provisioning.md— camelCase mirror of the above for ORM users (tableProvision,isVisible,skipEntityPolicies), with a TypeScript example and a note that JSONB inner keys stay snake_case.constructive/references/blueprint-definition-format.md— addstable_provisionto the top-levelmembership_typesfield table and updates theis_visible/skip_entity_policiesrows to reflect the new semantics (is_visibleis a no-op whentable_provisionis supplied;skip_entity_policiesis now framed as the escape hatch).Key semantic documented throughout:
skip_entity_policiestable_provisionis_visible)policies[]only;is_visibleis a no-oppolicies[]onlyReview & Testing Checklist for Human
insert_entity_type_provision.sql— specifically thattable_provisionnon-null always skips defaults, even when itspolicies[]is empty/absent (docs claim this, and note that callers wanting "custom fields + defaults" must copy the 5 defaults intopolicies[]).self_member,parent_member,admin_create,admin_update,admin_delete) match whatprovision_membership_tableemits — I pulled these from memory of PR #823/#824, not by regrepping the source in this session.#entity-table-policies-is_visible-skip_entity_policies-table_provisionwhich may or may not resolve cleanly depending on your MD renderer's slug algorithm (backticks + underscores are a known footgun).Notes
constructive-membership-types/SKILL.md(the top-level skill) was left alone — its CLI example only shows--isVisible/--skipEntityPolicies, and I didn't add--tableProvisionsince CLI args don't naturally carry nested JSON. The full story lives in the reference files linked from the skill.Link to Devin session: https://app.devin.ai/sessions/6aad642053f844439cbdbb0ce928bc08
Requested by: @pyramation