Skip to content

fix(presigned-url): match files→buckets by table name prefix instead of schema name #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pyramation merged 1 commit into from
May 8, 2026
Merged

fix(presigned-url): match files→buckets by table name prefix instead of schema name #1075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions graphile/graphile-presigned-url-plugin/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,12 +237,21 @@ export function createPresignedUrlPlugin(
const filesTypeName = (build.inflection as any).tableType(filesCodec);
const filesSchemaName = filesCodec.extensions?.pg?.schemaName;

// Find the matching bucket codec by schema name
const matchingBucketCodec = (bucketCodecs as any[]).find(
(bc: any) => bc.extensions?.pg?.schemaName === filesSchemaName,
);
// Find the matching bucket codec by table name prefix.
// Schema-name matching is ambiguous when multiple storage modules share
// the same PG schema (e.g. app_files + data_room_files both in storage_public).
// Instead, derive the prefix from the raw SQL table name:
// "data_room_files" → prefix "data_room" → matches "data_room_buckets"
// "app_files" → prefix "app" → matches "app_buckets"
const filesRawName = filesCodec.extensions?.pg?.name as string | undefined;
const filesPrefix = filesRawName?.replace(/_files$/, '');
const matchingBucketCodec = (bucketCodecs as any[]).find((bc: any) => {
const bucketRawName = bc.extensions?.pg?.name as string | undefined;
const bucketPrefix = bucketRawName?.replace(/_buckets$/, '');
return bucketPrefix === filesPrefix;
});
if (!matchingBucketCodec) {
log.debug(`Skipping create mutation for ${filesCodec.name}: no matching bucket codec in schema ${filesSchemaName}`);
log.debug(`Skipping upload mutation for ${filesCodec.name}: no matching bucket codec with prefix "${filesPrefix}"`);
continue;
}

Expand Down
Loading