feat: add CheckScopedForeignKey node type to registry#1278
Merged
Conversation
Registers denormalized field triggers as a proper node type. Creates INSERT/UPDATE triggers that copy field values from a referenced parent table into the current table whenever the FK changes. Used to denormalize frequently-read columns (e.g. database_id on junction tables) so RLS and queries can filter locally without joining.
BEFORE INSERT trigger validator that ensures all FK references resolve to the same scope value (e.g. database_id). Prevents cross-scope linking where a user with access to multiple scopes could create invalid cross-scope references. Works on junction tables (2+ FKs) and child tables (1 FK validated against the row's own scope field).
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
CheckScopedForeignKeyto the node type registry — a BEFORE INSERT trigger validator that prevents cross-scope FK linking.Problem: On junction tables (e.g.
view_tablewithview_id+table_id), a user with access to multiple databases can INSERT a row linking records from different databases. RLS only checks "can you access this row" — it doesn't validate that all FKs point to the same scope.Solution: New
Check*category node type withparameter_schema:The generator (in constructive-db) creates a BEFORE INSERT trigger that SELECTs each target's scope value and raises if any mismatch. Works for junction tables (2+ refs) and child tables (1 ref validated against the row's own scope field).
Companion PR: constructive-io/constructive-db (generator + table_module dispatch).
Link to Devin session: https://app.devin.ai/sessions/12842f98263d4815b6713291efc825ad
Requested by: @pyramation