Move req object and ApiModule to server/src/types#64
Closed
devin-ai-integration[bot] wants to merge 7 commits intomainfrom
Closed
Move req object and ApiModule to server/src/types#64devin-ai-integration[bot] wants to merge 7 commits intomainfrom
devin-ai-integration[bot] wants to merge 7 commits intomainfrom
Conversation
…th api Co-Authored-By: Dan Lynch <pyramation@gmail.com>
…modules Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move req object and ApiModule to server/src/types
This PR continues the refactoring work started in branch
devin/1748310514-refactor-apiinfo-structureby moving the server-specific types frompackages/typestopackages/server/src/types.Changes
packages/types/src/launchql.tstopackages/server/src/types.tspackages/server/src/middleware/cors.tsto reference the new locationMotivation
This change improves code organization by moving server-specific types to the server package where they're primarily used. The Express Request interface extension and API-related types are closely tied to server functionality and belong in the server package rather than the general types package.
Link to Devin run
https://app.devin.ai/sessions/f2f23a899c634cb995450e5c80c19d7f
Requested by: Dan Lynch (pyramation@gmail.com)