Skip to content

Move req object and ApiModule to server/src/types#64

Closed
devin-ai-integration[bot] wants to merge 7 commits intomainfrom
devin/1748333377-move-req-to-server-types
Closed

Move req object and ApiModule to server/src/types#64
devin-ai-integration[bot] wants to merge 7 commits intomainfrom
devin/1748333377-move-req-to-server-types

Conversation

@devin-ai-integration
Copy link
Contributor

Move req object and ApiModule to server/src/types

This PR continues the refactoring work started in branch devin/1748310514-refactor-apiinfo-structure by moving the server-specific types from packages/types to packages/server/src/types.

Changes

  • Moved the Express Request interface extension (req object) from packages/types/src/launchql.ts to packages/server/src/types.ts
  • Moved related API types (ApiModule, CorsModuleData, PublicKeyChallengeData, GenericModuleData, RlsModule) to server types
  • Updated imports in packages/server/src/middleware/cors.ts to reference the new location
  • Verified that no other files were directly importing these specific types

Motivation

This change improves code organization by moving server-specific types to the server package where they're primarily used. The Express Request interface extension and API-related types are closely tied to server functionality and belong in the server package rather than the general types package.

Link to Devin run

https://app.devin.ai/sessions/f2f23a899c634cb995450e5c80c19d7f

Requested by: Dan Lynch (pyramation@gmail.com)

devin-ai-integration bot and others added 5 commits May 27, 2025 01:53
…th api

Co-Authored-By: Dan Lynch <pyramation@gmail.com>
…modules

Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
@devin-ai-integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pyramation pyramation closed this May 29, 2025
@pyramation pyramation deleted the devin/1748333377-move-req-to-server-types branch June 21, 2025 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant