fix: remove dbname from sites and apis export config#711
Merged
pyramation merged 1 commit intomainfrom Feb 13, 2026
Merged
Conversation
The dbname column has DEFAULT current_database() which captures the random test database name during introspection, causing non-deterministic output in generated migration files (apis.sql, sites.sql). By removing dbname from the export config, the generated INSERT statements won't include this column, and it will use its DEFAULT at deploy time.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: exclude dbname from sites and apis export config
Summary
Removes
dbnamefrom thesitesandapisfield configs inexport-meta.tsso that generated migration INSERT statements no longer include this column.The
dbnamecolumn on bothservices_public.sitesandservices_public.apishasDEFAULT current_database(). During introspection, the test database receives a random name (e.g.db-<uuid>), so each regeneration produces a differentdbnamevalue in the exported SQL — causing non-deterministic diffs like:With
dbnameremoved from the config, the column is omitted from generated INSERTs entirely. At deploy time,current_database()provides the correct value via the column DEFAULT.Review & Testing Checklist for Human
dbnamebeing explicitly present in the migration INSERT statements (rather than relying on the column DEFAULT)constructive-dband confirmapis.sql/sites.sqlno longer containdbnameand produce stable output across runscsv-to-pgParsercorrectly omits columns not listed infields(i.e., confirmSELECT *rows with extra columns don't cause errors whendbnameis absent from the config)Notes
@pgpmjs/core). Theconstructive-dbrepo will need its dependency updated and migrations regenerated to see the effect.