fix: update @pgpmjs/core export config for grantee_name rename and add default_privilege table#752
Merged
pyramation merged 1 commit intomainfrom Feb 28, 2026
Conversation
…vilege table - policy config: role_name -> grantee_name - table_grant config: role_name -> grantee_name, add is_grant field - Add default_privilege table config with all fields - Add default_privilege queryAndParse call - Add default_privilege to tableOrder in export-migrations
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: update export config for grantee_name rename and default_privilege
Summary
Upstream the changes from the
@pgpmjs/corepnpm patch in constructive-db#542 into the source package. That PR renamedrole_name→grantee_nameontable_grant,view_grant, andpolicytables inmetaschema_public, addedis_granttotable_grant/view_grant, and created a newdefault_privilegetable.Changes in
export-meta.ts:policyconfig:role_name→grantee_nametable_grantconfig:role_name→grantee_name, addis_grant: 'boolean'default_privilegetable config (schema_id, object_type, privilege, grantee_name, is_grant)queryAndParsecall fordefault_privilegeaftertable_grantChanges in
export-migrations.ts:'default_privilege'totableOrderafter'table_grant'services_public.apis.role_nameis intentionally unchanged (different semantic context — API owner role, not a privilege grantee).Review & Testing Checklist for Human
default_privilegefields (id,database_id,schema_id,object_type,privilege,grantee_name,is_grant) must exactly match the columns onmetaschema_public.default_privilegeas deployed by constructive-db#542. Same fortable_grant(now hasgrantee_name+is_grant) andpolicy(now hasgrantee_name). Any mismatch will causebuildDynamicFieldsto silently drop columns.view_grantis still not in the export config — The companion PR addedis_grantand renamedrole_name→grantee_nameonview_granttoo, butview_grantwas never in the export config to begin with. Confirm this is intentional (i.e., view grants are not exported via this path).constructive-dbto use the new version, remove thepatches/@pgpmjs__core@6.3.0.patch, and run the full CI suite to confirm the generate step still passes without the patch.Notes