refactor(server): remove schema naming env var forwarding from pgSettings

[pyramation]

Summary

Removes the CONSTRUCTIVE_SIMPLE_SCHEMA_NAMES and CONSTRUCTIVE_SCHEMA_USE_UNDERSCORES environment variable forwarding from the GraphQL server's pgSettings context (added in PR #816).

These schema naming strategy settings are now configured at the database level via ALTER DATABASE SET during provision, so every PostgreSQL connection inherits them automatically. The server no longer needs to act as a pass-through for these values, keeping it generic and decoupled from schema naming concerns.

What changed: 9 lines removed from graphql/server/src/middleware/graphile.ts — the two if (process.env.CONSTRUCTIVE_*) blocks in buildPreset's context callback. No new code added.

Review & Testing Checklist for Human

• Verify all active databases have ALTER DATABASE SET configured — Any database that was relying on CONSTRUCTIVE_SIMPLE_SCHEMA_NAMES / CONSTRUCTIVE_SCHEMA_USE_UNDERSCORES env vars on the server must now have equivalent database-level settings (constructive.simple_schema_names, constructive.schema_use_underscores). Without this, schema creation will revert to default behavior (hash suffixes, dashes). Check with: psql <dbname> -c "SELECT name, setting FROM pg_db_role_setting WHERE setdatabase = (SELECT oid FROM pg_database WHERE datname = '<dbname>')" or SHOW constructive.simple_schema_names;
• Confirm no other consumers depend on these env vars — Grep across deployment configs, docker-compose files, CI pipelines, and Kubernetes manifests for CONSTRUCTIVE_SIMPLE_SCHEMA_NAMES or CONSTRUCTIVE_SCHEMA_USE_UNDERSCORES to ensure nothing else references them.
• Test a provision + schema creation cycle — After deploying this change, provision a new database and verify schema names are still clean (e.g., myapp_app_public not myapp_1234567_app_public).

Notes

• This is the inverse of PR feat: pass schema naming strategy env vars to pgSettings #816 — that PR added env var forwarding; this PR removes it in favor of the database-level approach.
• Build passes clean (full pnpm build).
• Requested by: @pyramation
• Devin Session

[devin-ai-integration]

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

• Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
• Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

• Disable automatic comment and CI monitoring