fix(node-type-registry): grant_privileges type is string[][] not string[]#928
Merged
pyramation merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
…ng[] The JSON schema for RelationManyToMany.grant_privileges was missing items definition, causing codegen to produce string[] instead of string[][]. The actual usage is array of [verb, columns] tuples, e.g. [['select','*'],['insert','*']].
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the JSON schema for
RelationManyToMany.grant_privilegeswhich was missing itsitemsdefinition, causing codegen to producestring[]instead of the correctstring[][].The actual runtime usage is an array of
[verb, columns]tuples — e.g.[['select','*'],['insert','*']]— so the schema now specifiesitems: { type: "array", items: { type: "string" } }.The regenerated
blueprint-types.generated.tsalso picks up cosmetic changes from recently merged PRs (#914, #915) that are now on main ($type→policy_typeonBlueprintPolicy, section comment updates, minor JSDoc tweaks onBlueprintIndex).Review & Testing Checklist for Human
$type→policy_typerename onBlueprintPolicy: The regenerated file renames this field. Verify that all consumers (agentic-db, constructive-db blueprints,construct_blueprint()SQL) already expectpolicy_typeand not$type. If any consumer still uses$type, this is a breaking change.grant_privilegescorrectness: Confirm thatconstruct_blueprint()andsecure_table_provisionactually consumegrant_privilegesas a 2D array (array of[verb, columns]tuples). If the server flattens or interprets it differently, the type could still be wrong.Notes
relation-many-to-many.ts(6 lines added to the JSON schemaitemsdefinition). Everything inblueprint-types.generated.tsis regenerated output.node-type-registry@0.6.0— the M2M relations withgrant_privileges: [['select','*'], ...]failed type checking.Link to Devin session: https://app.devin.ai/sessions/ce1b2dafd42341bea5d7793b0c05ba6c
Requested by: @pyramation