chore: remove all deprecated code, backward-compat aliases, and legacy shims#936
Merged
pyramation merged 1 commit intomainfrom Mar 30, 2026
Merged
Conversation
…y shims - Remove Sqitch aliases (writeSqitchFiles, writeSqitchPlan, SqitchRow) - Remove PgTextClientContext typo alias - Remove LegacyGraphileOptions interface and graphile field from GetConnectionsInput - Remove CustomInflectorPlugin/CustomInflectorPreset backward-compat re-exports - Remove deprecated NodeTypeRegistryPreset section from README - Remove deprecated --template-path CLI option handling - Delete codegen/core/query-builder.ts backward-compat re-export shim - Remove IntrospectionSchema backward-compat alias from codegen/core/types.ts - Move naming helper exports to canonical location in generators/index.ts - Remove legacy graphile options from playwright-test server setup - Clean up backward-compat comments throughout codebase - Remove DEPRECATED block from constructive-preset.ts
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all deprecated code, backward-compatibility aliases, type shims, and legacy interfaces across the monorepo. The build passes with these deletions.
Deleted exports/symbols:
writeSqitchFiles,writeSqitchPlan(aliases forwritePgpmFiles/writePgpmPlan)SqitchRowtype alias (forPgpmRow)PgTextClientContexttype alias (typo fix alias forPgTestClientContext)CustomInflectorPlugin,CustomInflectorPreset(aliases forInflektPlugin/InflektPreset)LegacyGraphileOptionsinterface +graphilefield fromGetConnectionsInputIntrospectionSchematype alias from codegen (alias forQueryIntrospectionSchema)codegen/src/core/query-builder.tsre-export shim file (deleted entirely)NodeTypeRegistryPresetsection from READMEOther changes:
toCamelCasePlural/toOrderByTypeNameexports fromselect.tsre-export to canonicalnaming-helperssource ingenerators/index.tsinput.graphilelegacy options forwarding fromplaywright-test--template-pathdeprecation comments from CLI (alias itself still registered)Review & Testing Checklist for Human
CustomInflectorPlugin,CustomInflectorPreset,LegacyGraphileOptions,SqitchRow,writeSqitchFiles,writeSqitchPlan,PgTextClientContext, orIntrospectionSchema. The monorepo build passes, but external consumers will break silently at their next build.--template-pathCLI alias inconsistency: The deprecation comment was removed frompgpm/cli/src/index.tsbut the alias'template-path': 'template'is still registered on line 37. Decide whether to remove the alias entirely (breaking) or keep it as a silent alias.graphilefield removal from playwright-test: Verify no existing Playwright test suites pass legacygraphileoptions viaGetConnectionsInput. Theinput.graphilespread was removed fromget-connections.ts:60.pnpm testor targeted package tests) — onlypnpm buildwas verified, not tests.Notes
convertFromMetaSchema/validateMetaObjectdirect exports fromgraphql/querywere initially removed as "backward-compat" but had to be restored becausegraphql/codegenimports them directly. They are part of the active public API, not legacy shims.Link to Devin session: https://app.devin.ai/sessions/9d1d1d33bd734370af00f8c60d72316b
Requested by: @pyramation