Skip to content

chore: remove all deprecated code, backward-compat aliases, and legacy shims#936

Merged
pyramation merged 1 commit intomainfrom
devin/1774901170-remove-deprecated-code
Mar 30, 2026
Merged

chore: remove all deprecated code, backward-compat aliases, and legacy shims#936
pyramation merged 1 commit intomainfrom
devin/1774901170-remove-deprecated-code

Conversation

@pyramation
Copy link
Copy Markdown
Contributor

Summary

Removes all deprecated code, backward-compatibility aliases, type shims, and legacy interfaces across the monorepo. The build passes with these deletions.

Deleted exports/symbols:

  • writeSqitchFiles, writeSqitchPlan (aliases for writePgpmFiles/writePgpmPlan)
  • SqitchRow type alias (for PgpmRow)
  • PgTextClientContext type alias (typo fix alias for PgTestClientContext)
  • CustomInflectorPlugin, CustomInflectorPreset (aliases for InflektPlugin/InflektPreset)
  • LegacyGraphileOptions interface + graphile field from GetConnectionsInput
  • IntrospectionSchema type alias from codegen (alias for QueryIntrospectionSchema)
  • codegen/src/core/query-builder.ts re-export shim file (deleted entirely)
  • Deprecated NodeTypeRegistryPreset section from README

Other changes:

  • Moved toCamelCasePlural/toOrderByTypeName exports from select.ts re-export to canonical naming-helpers source in generators/index.ts
  • Removed input.graphile legacy options forwarding from playwright-test
  • Removed --template-path deprecation comments from CLI (alias itself still registered)
  • Cleaned up "backward compat" phrasing from comments across ~10 files

Review & Testing Checklist for Human

  • External consumers of removed symbols: Grep any downstream repos/apps that import CustomInflectorPlugin, CustomInflectorPreset, LegacyGraphileOptions, SqitchRow, writeSqitchFiles, writeSqitchPlan, PgTextClientContext, or IntrospectionSchema. The monorepo build passes, but external consumers will break silently at their next build.
  • --template-path CLI alias inconsistency: The deprecation comment was removed from pgpm/cli/src/index.ts but the alias 'template-path': 'template' is still registered on line 37. Decide whether to remove the alias entirely (breaking) or keep it as a silent alias.
  • graphile field removal from playwright-test: Verify no existing Playwright test suites pass legacy graphile options via GetConnectionsInput. The input.graphile spread was removed from get-connections.ts:60.
  • Run the test suite (pnpm test or targeted package tests) — only pnpm build was verified, not tests.

Notes

  • The convertFromMetaSchema/validateMetaObject direct exports from graphql/query were initially removed as "backward-compat" but had to be restored because graphql/codegen imports them directly. They are part of the active public API, not legacy shims.

Link to Devin session: https://app.devin.ai/sessions/9d1d1d33bd734370af00f8c60d72316b
Requested by: @pyramation

…y shims

- Remove Sqitch aliases (writeSqitchFiles, writeSqitchPlan, SqitchRow)
- Remove PgTextClientContext typo alias
- Remove LegacyGraphileOptions interface and graphile field from GetConnectionsInput
- Remove CustomInflectorPlugin/CustomInflectorPreset backward-compat re-exports
- Remove deprecated NodeTypeRegistryPreset section from README
- Remove deprecated --template-path CLI option handling
- Delete codegen/core/query-builder.ts backward-compat re-export shim
- Remove IntrospectionSchema backward-compat alias from codegen/core/types.ts
- Move naming helper exports to canonical location in generators/index.ts
- Remove legacy graphile options from playwright-test server setup
- Clean up backward-compat comments throughout codebase
- Remove DEPRECATED block from constructive-preset.ts
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@pyramation pyramation merged commit a465477 into main Mar 30, 2026
84 of 85 checks passed
@pyramation pyramation deleted the devin/1774901170-remove-deprecated-code branch March 30, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant