fix: enable orderBy on all columns alongside filterBy in v5 plugin#937
Merged
pyramation merged 2 commits intomainfrom Mar 31, 2026
Merged
fix: enable orderBy on all columns alongside filterBy in v5 plugin#937pyramation merged 2 commits intomainfrom
pyramation merged 2 commits intomainfrom
Conversation
Contributor
Author
|
this is needed for the sorting by column features in dashboard side: Kapture.2026-03-31.at.05.12.20.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem: PostGraphile v5's PgIndexBehaviorsPlugin adds both -filterBy and -orderBy to non-indexed columns. The existing
EnableAllFilterColumnsPlugin only restored filterBy — it missed re-enabling orderBy.
The fix (this diff): Adds 'orderBy' alongside 'filterBy' in the behavior callback (line 77):
// Before
return [behavior, 'filterBy'];
// After
return [behavior, 'filterBy', 'orderBy'];
Impact: Without this, any column that doesn't have a database index would be missing from the orderBy enum in GraphQL
connections — meaning clients couldn't sort by those columns. This is a significant gap since the plugin's intent was always
to remove v5's index-only restriction.