feat: update RelationManyToMany types - replace node_type/node_data with nodes[] array#943
Merged
pyramation merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
…ith nodes[] array Matches constructive-db PR #723 which redesigns secure_table_provision and relation_provision to use a nodes jsonb array instead of separate node_type/node_data columns.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the
RelationManyToManynode type definition and generated blueprint types to replace the singlenode_type(string) +node_data(object) parameters with anodesarray of objects. Each object in the array has a$typekey identifying the generator (e.g.DataId,DataEntityMembership) plus optional data keys.This matches the DB schema change in constructive-db PR #723, which redesigns
relation_provision.node_type/node_datacolumns into a singlenodes jsonbcolumn.Files changed:
graphql/node-type-registry/src/relation/relation-many-to-many.ts— source definitiongraphql/node-type-registry/src/blueprint-types.generated.ts— regenerated viapnpm generate:typesReview & Testing Checklist for Human
nodestype shape matches DB expectation: The generated TS type is{ [key: string]: unknown }[]— it does NOT enforce$typeat the type level (the codegen derives from the JSON Schema"type": "array", "items": { "type": "object" }). Confirm this is acceptable or if the schema should be tightened to require$type.Notes
node_typeornode_dataonRelationManyToManyParamswill fail to compile. This is intentional (pre-launch, no backward compat).pnpm generate:typesingraphql/node-type-registry/, not hand-edited.Link to Devin session: https://app.devin.ai/sessions/094d88b562a04a2fa55dc2e4d85f7b8d
Requested by: @pyramation