Skip to content

refactor: rename Data* search node types to Search* equivalents in node-type-registry#954

Merged
pyramation merged 2 commits intomainfrom
devin/1775097093-rename-search-node-types
Apr 2, 2026
Merged

refactor: rename Data* search node types to Search* equivalents in node-type-registry#954
pyramation merged 2 commits intomainfrom
devin/1775097093-rename-search-node-types

Conversation

@pyramation
Copy link
Copy Markdown
Contributor

Summary

Renames 7 search-related node type definitions from Data* to Search* naming, aligning the node-type-registry with the generator renames already landed in constructive-db (PR #731). No backward-compat aliases — clean rename only per project policy (system hasn't launched).

Old Name New Name New Slug
DataEmbedding SearchVector search_vector
DataFullTextSearch SearchFullText search_full_text
DataBm25 SearchBm25 search_bm25
DataSearch SearchUnified search_unified
DataPostGIS SearchSpatial search_spatial
DataPostGISAggregate SearchSpatialAggregate search_spatial_aggregate
DataTrgm SearchTrgm search_trgm

Each definition updates: export name, name, slug, category (datasearch), display_name, and file name. Comment references in graphile-search and graphile-postgis updated to match.

Review & Testing Checklist for Human

  • Category change impact on codegen: All 7 nodes changed category from "data" to "search". Verify that generate-types.ts (which builds the BlueprintNode discriminated union from dataNodes) still includes these nodes after the category change — if it filters on category === 'data', they'll be silently dropped from the union type.
  • Generated files need regeneration: blueprint-types.generated.ts still exports DataEmbeddingParams, DataSearchParams, etc. After merge, run cd graphql/node-type-registry && pnpm generate:types and verify the generated output uses SearchVectorParams, SearchUnifiedParams, etc. Same for pnpm generate:seed if seeds are deployed.
  • Downstream SDK types: SDK packages (constructive-sdk, constructive-cli, constructive-react) have generated files referencing old Data* names in input-types.ts and schema-types.ts. Confirm these will be regenerated as part of the normal codegen pipeline.
  • constructive-db alignment: Verify the new name strings (SearchVector, SearchFullText, etc.) exactly match the WHEN clauses in table_module.sql from constructive-db PR feat(codegen): apiNames auto-expand, schemaDir, --schema-only, graphile-schema package, README headers #731.

Notes

  • Build passes cleanly (pnpm build succeeds across all workspace packages).
  • Non-search Data* node types (DataId, DataTimestamps, DataDirectOwner, etc.) are intentionally unchanged.
  • The search-unified.ts internal descriptions were also updated (DataFullTextSearch parametersSearchFullText parameters, etc.).

Link to Devin session: https://app.devin.ai/sessions/f6dc079489ad4d7b835d5eb892bb616f
Requested by: @pyramation

…de-type-registry

Renames:
- DataEmbedding → SearchVector
- DataFullTextSearch → SearchFullText
- DataBm25 → SearchBm25
- DataSearch → SearchUnified
- DataPostGIS → SearchSpatial
- DataPostGISAggregate → SearchSpatialAggregate
- DataTrgm → SearchTrgm

Updates name, slug, category (data → search) in each definition.
Updates comment references in graphile-search and graphile-postgis.
No backward-compat aliases — clean rename only.
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

…blueprint types

Without this, the search node parameter interfaces (SearchVectorParams, etc.)
would not be generated since categoryOrder only listed 'data', 'authz',
'relation', 'view'. Now includes 'search' so all 7 Search* param interfaces
are correctly generated.
@pyramation pyramation merged commit ea869ed into main Apr 2, 2026
45 checks passed
@pyramation pyramation deleted the devin/1775097093-rename-search-node-types branch April 2, 2026 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant