refactor: rename Data* search node types to Search* equivalents in node-type-registry#954
Merged
pyramation merged 2 commits intomainfrom Apr 2, 2026
Merged
Conversation
…de-type-registry Renames: - DataEmbedding → SearchVector - DataFullTextSearch → SearchFullText - DataBm25 → SearchBm25 - DataSearch → SearchUnified - DataPostGIS → SearchSpatial - DataPostGISAggregate → SearchSpatialAggregate - DataTrgm → SearchTrgm Updates name, slug, category (data → search) in each definition. Updates comment references in graphile-search and graphile-postgis. No backward-compat aliases — clean rename only.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…blueprint types Without this, the search node parameter interfaces (SearchVectorParams, etc.) would not be generated since categoryOrder only listed 'data', 'authz', 'relation', 'view'. Now includes 'search' so all 7 Search* param interfaces are correctly generated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Renames 7 search-related node type definitions from
Data*toSearch*naming, aligning the node-type-registry with the generator renames already landed in constructive-db (PR #731). No backward-compat aliases — clean rename only per project policy (system hasn't launched).DataEmbeddingSearchVectorsearch_vectorDataFullTextSearchSearchFullTextsearch_full_textDataBm25SearchBm25search_bm25DataSearchSearchUnifiedsearch_unifiedDataPostGISSearchSpatialsearch_spatialDataPostGISAggregateSearchSpatialAggregatesearch_spatial_aggregateDataTrgmSearchTrgmsearch_trgmEach definition updates: export name,
name,slug,category(data→search),display_name, and file name. Comment references ingraphile-searchandgraphile-postgisupdated to match.Review & Testing Checklist for Human
categoryfrom"data"to"search". Verify thatgenerate-types.ts(which builds theBlueprintNodediscriminated union fromdataNodes) still includes these nodes after the category change — if it filters oncategory === 'data', they'll be silently dropped from the union type.blueprint-types.generated.tsstill exportsDataEmbeddingParams,DataSearchParams, etc. After merge, runcd graphql/node-type-registry && pnpm generate:typesand verify the generated output usesSearchVectorParams,SearchUnifiedParams, etc. Same forpnpm generate:seedif seeds are deployed.constructive-sdk,constructive-cli,constructive-react) have generated files referencing oldData*names ininput-types.tsandschema-types.ts. Confirm these will be regenerated as part of the normal codegen pipeline.namestrings (SearchVector,SearchFullText, etc.) exactly match theWHENclauses intable_module.sqlfrom constructive-db PR feat(codegen): apiNames auto-expand, schemaDir, --schema-only, graphile-schema package, README headers #731.Notes
pnpm buildsucceeds across all workspace packages).Data*node types (DataId, DataTimestamps, DataDirectOwner, etc.) are intentionally unchanged.search-unified.tsinternal descriptions were also updated (DataFullTextSearch parameters→SearchFullText parameters, etc.).Link to Devin session: https://app.devin.ai/sessions/f6dc079489ad4d7b835d5eb892bb616f
Requested by: @pyramation