test: MinIO integration tests for presigned URL s3-signer (Step 2h)#959
Merged
pyramation merged 2 commits intomainfrom Apr 3, 2026
Merged
test: MinIO integration tests for presigned URL s3-signer (Step 2h)#959pyramation merged 2 commits intomainfrom
pyramation merged 2 commits intomainfrom
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds integration tests for the
s3-signermodule ingraphile-presigned-url-plugin, exercising presigned URL generation and S3 operations against a real MinIO instance. Also adds the package to the CI test matrix and fixes the CI env var name (MINIO_ENDPOINT→CDN_ENDPOINT) to match the codebase after PR #948 removed allminioEndpointreferences.12 tests covering:
generatePresignedPutUrl— URL generation + actual PUT upload via presigned URLheadObject— metadata verification, 404 handling, content-type mismatch detectiongeneratePresignedGetUrl— URL generation + actual GET download, Content-Disposition, expiryCI changes:
MINIO_ENDPOINT→CDN_ENDPOINTinrun-tests.yamlglobal env (the app code no longer readsMINIO_ENDPOINTsince PR feat: wire PresignedUrlPreset into ConstructivePreset (Step 2g) #948)graphile/graphile-presigned-url-pluginto the test matrixUpdates since last revision
NODE_OPTIONS='--experimental-vm-modules'from the test script. The existing@smithy/node-http-handlerpin (<4.5.0) in the rootpackage.json(from PR fix: pin @smithy/node-http-handler <4.5.0 to fix Jest VM dynamic import issue #951) is sufficient to avoid the Jest VM dynamic import issue in CI. No special flags needed.Review & Testing Checklist for Human
MINIO_ENDPOINT→CDN_ENDPOINTrename doesn't break other CI test packages —uploads/s3-streamerusesgetEnvOptions()which readsCDN_ENDPOINT(or falls back topgpmDefaults.cdn.endpoint = 'http://localhost:9000'). Grep the repo for any directprocess.env.MINIO_ENDPOINTreads that may still exist.graphile/graphile-presigned-url-pluginneeds MinIO available (via theminio_cdnservice). Confirm the test job passes on this PR's CI run without--experimental-vm-modules.@smithy/node-http-handlerpin from PR fix: pin @smithy/node-http-handler <4.5.0 to fix Jest VM dynamic import issue #951 is still present — these tests depend on the rootpackage.jsonpnpm override ("@smithy/node-http-handler": "<4.5.0"). If that pin is ever removed, tests will fail withERR_VM_DYNAMIC_IMPORT_CALLBACK_MISSING_FLAG.Notes
test-put-basic.txt). Re-runs against the same MinIO instance are safe sincecreateS3BuckethandlesBucketAlreadyOwnedByYou, but stale objects from prior runs could mask upload failures in thebeforeAllsetup blocks.@constructive-io/s3-utilsworkspace devDependency link.Bufferuploads) due to TypeScriptfetchbody type constraints. The underlying S3 operations are identical regardless of body encoding.Link to Devin session: https://app.devin.ai/sessions/4c882ba2dfbf4045adf85fb83cde6f77
Requested by: @pyramation