feat(pgpm): replace --include with --minio flag for docker command#977
Merged
pyramation merged 2 commits intomainfrom Apr 11, 2026
Merged
feat(pgpm): replace --include with --minio flag for docker command#977pyramation merged 2 commits intomainfrom
pyramation merged 2 commits intomainfrom
Conversation
- Replace --include <svc> with direct --minio flag matching pgpm env pattern - Simplify resolveServiceFlags to check args directly against ADDITIONAL_SERVICES keys - Remove parseInclude/resolveIncludedServices in favor of simpler resolveServiceFlags - Update help text and examples to use --minio instead of --include minio
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
pgpm docker start --include miniowith the simplerpgpm docker start --minio, matching the--minioflag pattern already used inpgpm env(PR #976).parseInclude()andresolveIncludedServices()(which parsed--include <name>args and did name lookups with warnings for unknown services)resolveServiceFlags()which checks CLI args directly againstADDITIONAL_SERVICESkeys — ifargs.miniois truthy, the minio service is included--minioflag syntaxpgpm docker lshint from--include <name>to--<name> flagdisplay.tstop-level help to show--minioinstead of--include for additional servicesBreaking:
--include miniono longer works. Since #975 was merged very recently, adoption is near-zero.Review & Testing Checklist for Human
--minioflag parsing: Runpgpm docker start --minioand confirminquirererparses it as{ minio: true }soresolveServiceFlagspicks it up. The old--includeapproach explicitly handled string/array parsing; the new approach assumes the arg parser sets a boolean — confirm this works with the actual CLI arg parserpgpm docker start --minio(both containers up),pgpm docker ls(shows minio status),pgpm docker stop --minio(both stop)--miniodoesn't collide with other args: The newresolveServiceFlagsiterates allADDITIONAL_SERVICESkeys and checksargs[key]— confirm no existing arg names clash with service names (currently onlyminio, so low risk)Notes
ADDITIONAL_SERVICEShas a key that works as a CLI flag name (e.g., no spaces, hyphens are fine). This is a reasonable constraint.Link to Devin session: https://app.devin.ai/sessions/44eca4b3fe5a46aaaf5c4907f0a0b600
Requested by: @pyramation