Skip to content

fix: drop /route from node type identifiers — category:name only#7

Merged
pyramation merged 1 commit into
mainfrom
feat/drop-route-from-node-type
Jul 4, 2026
Merged

fix: drop /route from node type identifiers — category:name only#7
pyramation merged 1 commit into
mainfrom
feat/drop-route-from-node-type

Conversation

@pyramation

Copy link
Copy Markdown

Summary

Removes the optional /route suffix from node type identifiers per constructive-planning#1110. The canonical format is now category:name only — / is rejected.

Schema validation — both JSON schemas add "pattern": "^[^/]+$" on NodeDefinition.name/type:

# packages/types/graph.schema.json (NodeDefinition.type)
# packages/spec/graph.schema.json  (NodeDefinition.name)
+"pattern": "^[^/]+$",
+"description": "... Slash (/) is not allowed."

Docs@fbp/types README Node Type Convention section:

-category:name[/route]
+category:name

-* **`/route`** (optional) — sub-route for multi-method containers
+The **slash** (`/`) character is **not allowed** in node type names.
+The name doubles as the HTTP route for HTTP-dispatched nodes.

Examples — all READMEs and skill references updated from slash-separated format to colon:

-type: 'js/math/add'       →  name: 'add'  (on NodeDefinition)
-type: 'js/math/add'       →  type: 'math:add'  (on Node instances)
-type: 'math/multiply'     →  type: 'math:multiply'
-email:postmaster/send     →  (removed)

Version@fbp/types bumped 1.1.01.2.0.

Build passes, all 43 evaluator tests pass.

Link to Devin session: https://app.devin.ai/sessions/e57db035e5d44bf184515ceb100083c6
Requested by: @pyramation

- Remove [/route] suffix from Node Type Convention in @fbp/types README
- Add pattern ^[^/]+$ to NodeDefinition name/type in both JSON schemas
- Update all README examples from slash-separated (math/add) to colon format (math:add)
- Update skill references to use category:name format
- Bump @fbp/types to 1.2.0

Closes constructive-io/constructive-planning#1110
@pyramation pyramation self-assigned this Jul 4, 2026
@devin-ai-integration

Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@pyramation pyramation merged commit 15cc13b into main Jul 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant