fix: drop /route from node type identifiers — category:name only#7
Merged
Conversation
- Remove [/route] suffix from Node Type Convention in @fbp/types README - Add pattern ^[^/]+$ to NodeDefinition name/type in both JSON schemas - Update all README examples from slash-separated (math/add) to colon format (math:add) - Update skill references to use category:name format - Bump @fbp/types to 1.2.0 Closes constructive-io/constructive-planning#1110
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the optional
/routesuffix from node type identifiers per constructive-planning#1110. The canonical format is nowcategory:nameonly —/is rejected.Schema validation — both JSON schemas add
"pattern": "^[^/]+$"onNodeDefinition.name/type:Docs —
@fbp/typesREADME Node Type Convention section:Examples — all READMEs and skill references updated from slash-separated format to colon:
Version —
@fbp/typesbumped1.1.0→1.2.0.Build passes, all 43 evaluator tests pass.
Link to Devin session: https://app.devin.ai/sessions/e57db035e5d44bf184515ceb100083c6
Requested by: @pyramation