Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 6, 2025

What

  • route the Plex loader CLI path through the staged loader orchestrator
  • log when the staged loader starts in Plex mode

Why

  • align the live Plex execution path with the staged loader architecture and reuse shared orchestration logic

Affects

  • mcp_plex/loader/__init__.py

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • n/a

https://chatgpt.com/codex/tasks/task_e_68e337ecfefc83288df0c5295a655048

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex/loader
   __init__.py79113683%182–189, 238, 324–329, 931–932, 976, 978, 1016, 1044–1045, 1056–1058, 1061, 1064–1065, 1067, 1089, 1099, 1110–1142, 1157, 1159, 1166–1180, 1183–1197, 1203, 1218–1249, 1254–1287, 1290–1294, 1299–1307, 1317, 1382–1384, 1396, 1530–1532, 1596–1613, 1955
mcp_plex/loader/pipeline
   __init__.py15753%57–62, 68
   channels.py73297%19–20
   enrichment.py3374387%78, 80, 87, 91, 170, 191, 211, 219–221, 228–231, 234–236, 244, 301, 357, 380, 384, 386, 412, 430, 442, 471, 477, 480–488, 514, 538, 609, 612–614
   ingestion.py81890%67, 98–108, 129, 157, 179
   orchestrator.py85594%48, 112, 141, 164–165
   persistence.py124993%112, 154–155, 165, 170, 174–176, 214
mcp_plex/server
   __init__.py6142995%43–44, 119–120, 148, 252, 256, 277–280, 297, 362, 365, 402, 420–421, 458, 1109, 1131–1137, 1173, 1191, 1196, 1214, 1338, 1375
   __main__.py440%3–8
   config.py48785%50, 52–55, 65, 76
TOTAL237425089% 

Tests Skipped Failures Errors Time
128 0 💤 0 ❌ 0 🔥 46.967s ⏱️

@Teagan42 Teagan42 merged commit 23ee310 into main Oct 6, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/refactor-run-function-for-loader-orchestration branch October 6, 2025 03:36
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

plex_chunk_size=plex_chunk_size,
enrichment_batch_size=enrichment_batch_size,
enrichment_workers=enrichment_workers,
upsert_buffer_size=upsert_buffer_size,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Live Plex CLI now uses stubbed staged ingestion

Switching the live branch to _build_loader_orchestrator means the CLI now runs the staged IngestionStage, but that stage still contains only placeholder logic that fetches media via .movies()/.shows() attributes and never calls the real Plex API. When run against an actual plexapi.PlexServer, those attributes do not exist so no batches are enqueued and the loader finishes with zero items. The legacy LegacyLoaderPipeline previously invoked _ingest_from_plex() which walked the Plex library correctly. This change therefore breaks real Plex ingestion entirely.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants