Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 7, 2025

What

  • move the TypedDict definitions from mcp_plex/server/__init__.py into a new mcp_plex/server/models.py
  • import the shared models from the new module and remove redundant typing imports in the server package entrypoint

Why

  • keep the server entrypoint focused on runtime logic and centralize shared typing structures in a dedicated module for reuse

Affects

  • mcp_plex/server/__init__.py
  • mcp_plex/server/models.py

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • not needed

https://chatgpt.com/codex/tasks/task_e_68e4b849ed3883288e133883189ba1c8

@github-actions
Copy link

github-actions bot commented Oct 7, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex/common
   validation.py28293%37–38
mcp_plex/loader
   __init__.py3741795%84–91, 165, 255–260, 662, 777–779, 781, 867–886
   __main__.py440%2–8
   imdb_cache.py43295%59, 63
mcp_plex/loader/pipeline
   channels.py64297%134–135
   enrichment.py5167585%237, 259–265, 318, 323, 354, 356, 363, 367, 471, 492, 512, 520–522, 525–527, 530–532, 540–545, 553, 607–608, 632, 692–693, 709, 738, 745, 747, 751, 803, 821, 833, 862, 868, 871–879, 905, 908–910, 927–929, 949–952, 956, 970–976, 998, 1000, 1003–1005
   ingestion.py1551392%81, 130–150, 185, 222, 238, 331, 337, 357
   orchestrator.py95595%63, 141, 170, 193–194
   persistence.py130993%122, 164–165, 175, 186, 190–192, 245
mcp_plex/server
   __init__.py6994394%58–59, 139–140, 159, 176, 226, 248–249, 259, 339, 360–363, 377–380, 388, 462, 465, 503, 521–522, 560, 988, 1261, 1284–1292, 1329, 1347, 1353, 1371, 1470–1472, 1476
   __main__.py440%3–8
   cli.py62198%73
   config.py821285%58, 61–69, 76, 82, 102, 116
TOTAL257518993% 

Tests Skipped Failures Errors Time
157 0 💤 0 ❌ 0 🔥 1m 19s ⏱️

@Teagan42 Teagan42 merged commit 28572ef into main Oct 7, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/move-typeddicts-to-new-module branch October 7, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants