Skip to content

Conversation

@Teagan42
Copy link
Contributor

What

  • add a supported mapping of Qdrant dense embedding models to size/distance pairs and use it in the loader
  • raise a clear error when an unknown model is requested and document the approach in AGENTS.md
  • expand loader tests to exercise the mapping and the unknown-model failure path while bumping the project version

Why

  • qdrant-client dropped the private _get_model_params helper, so the loader needs a supported replacement and explicit failure handling

Affects

  • server-side embedding configuration in the loader and its associated tests

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • updated AGENTS.md with the new loader strategy

https://chatgpt.com/codex/tasks/task_e_68d2ae182bf48328b5cc54495f652009

Copilot AI review requested due to automatic review settings September 23, 2025 14:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes dependency on a private Qdrant client API by implementing local model parameter mapping. The change replaces the removed _get_model_params helper with a supported dictionary mapping of dense embedding models to their vector dimensions and distance metrics.

  • Add local mapping of Qdrant dense embedding models to size/distance parameters
  • Replace private API call with explicit model parameter resolution
  • Add error handling for unknown models with clear documentation guidance

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
mcp_plex/loader.py Adds model parameter mapping and resolution function, removes private API usage
tests/test_loader_unit.py Tests the new model parameter resolution function for both known and unknown models
tests/test_loader_integration.py Integration test for unknown model error handling
AGENTS.md Documents the new approach for model metadata tracking
pyproject.toml Version bump

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings September 23, 2025 14:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Sep 23, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex
   loader.py3922494%118, 147–151, 153–162, 173, 175–177, 213, 615–617
   server.py3182193%107–108, 231, 459, 463, 485–491, 523, 533, 564–565, 582–583, 606, 609–610, 657, 694
TOTAL8914595% 

Tests Skipped Failures Errors Time
66 0 💤 0 ❌ 0 🔥 33.602s ⏱️

@Teagan42 Teagan42 merged commit 111983b into main Sep 23, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/replace-_get_model_params-with-strategy branch September 30, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants