Skip to content

Conversation

@Teagan42
Copy link
Contributor

@Teagan42 Teagan42 commented Oct 5, 2025

Summary

  • add ADR 0002 describing the loader multi-worker pipeline and its consequences
  • bump project version metadata to 0.26.60 and refresh uv.lock to stay consistent

Why

  • document the architectural decision behind the loader multi-worker rearchitecture that landed previously

Affects

  • docs/adr, version metadata in pyproject, docker manifest, and lockfile

Testing

  • uv run ruff check .
  • uv run pytest

Documentation

  • added ADR 0002 covering the loader multi-worker pipeline

https://chatgpt.com/codex/tasks/task_e_68e24fabf7e08328a7c77a11950f3fa7

Copilot AI review requested due to automatic review settings October 5, 2025 11:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR documents the loader multi-worker pipeline architecture and bumps the project version to 0.26.60. The main purpose is to add ADR 0002 explaining the architectural decision behind the loader's transition from sequential to parallel processing with multiple workers.

Key changes:

  • Add comprehensive ADR documentation for the multi-worker pipeline design
  • Refactor loader tests to use the new LoaderPipeline class instead of legacy functions
  • Update version metadata across project files to maintain consistency

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/adr/0002-loader-pipeline-multi-worker.md New ADR documenting the multi-worker pipeline architecture and design rationale
tests/test_loader_unit.py Updated tests to use LoaderPipeline class and new build_point function
tests/test_loader_logging.py Refactored logging tests to work with pipeline-based architecture
mcp_plex/loader/init.py Added LoaderPipeline class and supporting functions for multi-worker processing
pyproject.toml Version bump to 0.26.60
docker/pyproject.deps.toml Version bump to 0.26.60 for Docker builds

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

summary="Summary",
year=2024,
added_at=datetime.fromtimestamp(1),
guids=[PlexGuid(id="plex://1")],
Copy link

Copilot AI Oct 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removed thumb and art fields from the test data could indicate missing test coverage for these fields in the build_point function. Consider adding explicit tests to verify thumb and art field handling.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link

github-actions bot commented Oct 5, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
mcp_plex/loader
   __init__.py84913185%243, 298, 300–302, 318, 404–409, 1011–1012, 1056, 1058, 1113–1114, 1125–1127, 1130, 1133–1134, 1136, 1158, 1168, 1179–1211, 1226, 1228, 1235–1249, 1252–1266, 1272, 1287–1318, 1323–1356, 1359–1363, 1368–1376, 1386, 1395, 1399–1401, 1520–1522, 1855
mcp_plex/server
   __init__.py6142995%43–44, 119–120, 148, 252, 256, 277–280, 297, 362, 365, 402, 420–421, 458, 1109, 1131–1137, 1173, 1191, 1196, 1214, 1338, 1375
   __main__.py440%3–8
   config.py48785%50, 52–55, 65, 76
TOTAL171717190% 

Tests Skipped Failures Errors Time
101 0 💤 0 ❌ 0 🔥 1m 0s ⏱️

@Teagan42 Teagan42 merged commit de738ea into main Oct 5, 2025
4 checks passed
@Teagan42 Teagan42 deleted the codex/implement-loader-multi-worker-rearchitecture branch October 5, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants