Play Your Cards Right #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| constructor() { | ||
| super(); | ||
| this.state = { | ||
| url: 'https://deckofcardsapi.com/api/deck/new/draw/?count=52', |
Contributor
There was a problem hiding this comment.
since url does not change, it can just live in a const outside of class
| fetch(url) | ||
| .then(response => response.json()) | ||
| .then(data => { | ||
| this.setState( |
Contributor
There was a problem hiding this comment.
There is too much going on here. Especially with mulitple levels of callbacks. This could be done using a single setState call.
const cleanCards = this.cleanData(data.cards)
this.setState({
allCards: this.state.allCards.concat(cleanCards),
cardsReady: true
});
| }); | ||
|
|
||
| test('cardShuffle should return a randomised array', () => { | ||
| const mockRandom = jest.fn(); |
Contributor
|
Great work. Love the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Managing state in the top level of the app and extensive conditional rendering of dumb components made this quite complex.
Some of the components are unnecessarily granular, but this was to try out props.children and making elements suchs as buttons as reusable as possible.