Replacing consulo.ide.impl.idea.openapi.vfs.VfsUtil with consulo.virtualFileSystem.util.VirtualFileUtil#67
Conversation
…ualFileSystem.util.VirtualFileUtil.
There was a problem hiding this comment.
Pull request overview
This PR migrates Groovy plugin code away from the legacy consulo.ide.impl.idea.openapi.vfs.VfsUtil/VfsUtilCore helpers toward consulo.virtualFileSystem.util.VirtualFileUtil, aligning VFS usage with the Consulo virtual file system utilities.
Changes:
- Replaced
VfsUtiltext read/write helpers withVirtualFileUtilequivalents. - Replaced
VfsUtilCorehelpers (virtualToIoFile,isAncestor,getRelativePath,toVirtualFileArray) withVirtualFileUtil(andFileUtil.isAncestorwhere applicable). - Adjusted imports accordingly across Groovy MVC/Griffon/config/inspection code.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/org/jetbrains/plugins/groovy/GroovyGotoImplementationTest.java | Swaps VfsUtil.saveText for VirtualFileUtil.saveText in a test setup. |
| groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/mvc/MvcFramework.java | Replaces legacy VFS ancestor and virtualToIoFile helpers with FileUtil/VirtualFileUtil. |
| groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/griffon/GriffonFramework.java | Replaces file text loading and virtualToIoFile conversions with VirtualFileUtil. |
| groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/griffon/GriffonDefaultImportContributor.java | Replaces isAncestor checks with VirtualFileUtil.isAncestor. |
| groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/config/GroovyLibraryPresentationProviderBase.java | Uses VirtualFileUtil.toVirtualFileArray for library detection. |
| groovy-impl/src/main/java/org/jetbrains/plugins/groovy/impl/codeInspection/resources/TypeCustomizerInspection.java | Uses VirtualFileUtil.getRelativePath for resource pattern creation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -44,7 +41,7 @@ protected void run(Result result) throws Throwable { | |||
| final VirtualFile outside = dirFixture.getFile("").createChildDirectory(this, "outside"); | |||
| PsiTestUtil.addContentRoot(myModule, outside); | |||
| VirtualFile out = outside.createChildData(this, "Outside.groovy"); | |||
| consulo.ide.impl.idea.openapi.vfs.VfsUtil.saveText(out, "class Bar {}\n class Goo extends Bar {}"); | |||
| VirtualFileUtil.saveText(out, "class Bar {}\n class Goo extends Bar {}"); | |||
| } | |||
There was a problem hiding this comment.
VirtualFileUtil.saveText(...) is used but VirtualFileUtil isn’t imported, so this test won’t compile. Add the appropriate consulo.virtualFileSystem.util.VirtualFileUtil import (or fully-qualify the call), and ensure the VirtualFile type used here matches the saveText method signature (may require switching from com.intellij.openapi.vfs.VirtualFile to the Consulo VirtualFile type or casting).
No description provided.