You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enum/value separation. The match ptr.xmltype branches like | XPathTypeBoolean() => XPathTypeBoolean ; return … suggest those patterns may be vestigial (the first part is never used). If so, drop the XPathTypeBoolean ; side‑effect and just return (ptr.boolval == 1).
Document unsupported cases. You currently return None for Point, Range, LocationSet, Users, XsltTree. That’s a reasonable MVP, but:
Add a comment at the type alias site (Xml2XPathResult) noting that those XPath types collapse to None.
Consider logging (debug) when encountering unsupported types to help debugging.
Xml2XPathObject
Enum/value separation. The match ptr.xmltype branches like | XPathTypeBoolean() => XPathTypeBoolean ; return … suggest those patterns may be vestigial (the first part is never used). If so, drop the XPathTypeBoolean ; side‑effect and just return (ptr.boolval == 1).
Document unsupported cases. You currently return None for Point, Range, LocationSet, Users, XsltTree. That’s a reasonable MVP, but:
Add a comment at the type alias site (Xml2XPathResult) noting that those XPath types collapse to None.
Consider logging (debug) when encountering unsupported types to help debugging.