Adds serialization API#25
Merged
Merged
Conversation
This adds serialize() and saveToFile() methods to Xml2Doc, enabling XML documents to be saved to strings or files with optional formatting and encoding control. Implementation: - Added serialize() method using xmlDocDumpFormatMemoryEnc for in-memory serialization with format and encoding options - Added saveToFile() method using xmlSaveFormatFileEnc for direct file output - Added xmlFree wrapper to raw API for proper memory management - Both methods support pretty-printing and multiple character encodings (UTF-8, ISO-8859-1, UTF-16, etc.) Testing: - Added 6 comprehensive test cases covering round-trip serialization, formatting options, file I/O, encoding support, modified document serialization, and error handling - All 33 tests pass successfully This feature enables both modifying existing XML documents and provides the foundation for creating new XML documents from scratch. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Corrected the handling of Pointer[Pointer[T]] parameters in the serialize() method to use idiomatic Pony FFI patterns. Changes: - Use addressof operator with ref variables instead of array workaround - Retrieve libxml2's free function via xmlMemGet and call it as a function pointer instead of calling @xmlMemFree directly - Use String.from_cpointer() with known size instead of from_cstring() - Define XmlFreeFunc type for proper function pointer handling - Fixed xmlMemGet signature in raw API (use Pointer[Pointer[None]] not NullablePointer[Pointer[None]]) This is the correct and idiomatic way to handle C output parameters and function pointers in Pony's FFI. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Collaborator
Author
|
Hi @redvers, The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do. Release notes are added by creating a uniquely named file in the The basic format of the release notes (using markdown) should be: Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add document serialization APIs to high-level Pony API.