Skip to content

ls upgrade#28

Merged
contagon merged 8 commits into
masterfrom
ls-upgrade
Apr 26, 2025
Merged

ls upgrade#28
contagon merged 8 commits into
masterfrom
ls-upgrade

Conversation

@contagon
Copy link
Copy Markdown
Owner

Add a number of additional options to the ls command - version for pipeline, models and disk size for datasets.

@contagon contagon requested a review from Copilot April 26, 2025 00:40
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the ls command by adding additional dataset options (pipeline version, sensor brand/model, and disk size) and updating dataset-specific metadata methods. Key changes include removal of redundant static URL methods in loading params, addition of detailed dataset info methods (environment, vehicle), and enhancements to CLI table output with new columns for sensor info and disk size.

Reviewed Changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated no comments.

Show a summary per file
File Description
python/evalio/datasets/*.py Removed earlier url() implementations and added dataset info
python/evalio/cli/ls.py Expanded output table with new columns and added unique() helper
python/evalio/cli/dataset_manager.py Updated type import to use standard typing.Annotated
python/evalio/cli/writer.py & run.py Updated tqdm import to use tqdm.rich
cpp/evalio/* and cpp/bindings/* Added brand/model fields and a version() method in pipelines
Files not reviewed (1)
  • cpp/bindings/CMakeLists.txt: Language not supported
Comments suppressed due to low confidence (2)

python/evalio/cli/ls.py:98

  • [nitpick] The '--links' option is used in an inverted way (i.e., when false, the URL is wrapped as a hyperlink). Consider renaming the option (e.g., to 'use_hyperlink') or adding a clarifying comment to make its behavior more intuitive.
links_str = d.url()

python/evalio/cli/dataset_manager.py:3

  • [nitpick] Switching from 'typing_extensions.Annotated' to 'typing.Annotated' may affect compatibility with earlier Python versions. Ensure that the project’s minimum Python version supports this change, or consider a fallback to maintain compatibility.
from typing import Annotated

@contagon contagon merged commit f332fac into master Apr 26, 2025
11 checks passed
@contagon contagon deleted the ls-upgrade branch April 26, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants