Skip to content

Pipeline Upgrades#42

Merged
contagon merged 5 commits into
masterfrom
feature/pipeline-update
Sep 10, 2025
Merged

Pipeline Upgrades#42
contagon merged 5 commits into
masterfrom
feature/pipeline-update

Conversation

@contagon
Copy link
Copy Markdown
Owner

This PR makes a handful of upgrades to the pipeline class. This will make some breaking changes, but I don't think we have many users yet, so now is the time! Specifically,

  • add_lidar and map both now return dictionaries of points to enable visualizing the different features found in the pipeline.
  • rerun visualizing has been updated to handle these features.
  • rerun visualizer also now uses distinctipy to ensure we are utilizing distinct colors in rerun. No more similar colors! 🎉
  • New EVALIO_PARSE_PARAMS macro that automatically implements both default_params and set_params. This should help ensure there isn't any discrepancy between the two functions and remove probably the most tedious part of writing a pipeline wrapper.
  • As part of this, the python parser now receives back any unused parameters and errors out. This should have been caught earlier, but just in case we double check.

I think that's about it. More to come!

@contagon contagon requested a review from Copilot September 10, 2025 20:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes significant upgrades to the pipeline system to improve visualization and parameter handling. The changes enable better feature visualization through distinct colors and introduce a new macro system for parameter management.

  • Updated add_lidar and map methods to return dictionaries of feature types instead of flat point lists
  • Enhanced rerun visualization with distinctipy for distinct colors and improved feature rendering
  • Introduced EVALIO_PARSE_PARAMS macro to streamline parameter definition and reduce boilerplate code

Reviewed Changes

Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
python/evalio/rerun.py Major rerun visualization overhaul with distinctipy colors and dictionary-based feature handling
python/evalio/datasets/botanic_garden.py Fixed sequence name comparison bug
python/evalio/cli/parser.py Added warning for unused pipeline parameters
python/evalio/cli/dataset_manager.py Enhanced dataset removal to handle directories
pyproject.toml Added distinctipy dependency
docs/quickstart.md Updated rerun API calls
docs/examples/data_loading.md Updated rerun API calls
cpp/evalio/pipeline.h Updated interface to return feature dictionaries
cpp/evalio/macros.h New macro system for parameter handling
cpp/bindings/pipelines/loam.h Converted to use new macro system
cpp/bindings/pipelines/lio_sam.h Converted to use new macro system
cpp/bindings/pipelines/kiss_icp.h Converted to use new macro system
cpp/bindings/pipeline.h Updated bindings for new interface
README.md Updated rerun API calls
.clang-format Changed escape newline alignment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread python/evalio/rerun.py
Comment thread python/evalio/rerun.py
Comment thread cpp/evalio/macros.h
Comment thread python/evalio/rerun.py
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@contagon contagon merged commit ffd3d91 into master Sep 10, 2025
12 checks passed
@contagon contagon deleted the feature/pipeline-update branch September 10, 2025 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants