Pipeline Upgrades#42
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes significant upgrades to the pipeline system to improve visualization and parameter handling. The changes enable better feature visualization through distinct colors and introduce a new macro system for parameter management.
- Updated
add_lidarandmapmethods to return dictionaries of feature types instead of flat point lists - Enhanced rerun visualization with
distinctipyfor distinct colors and improved feature rendering - Introduced
EVALIO_PARSE_PARAMSmacro to streamline parameter definition and reduce boilerplate code
Reviewed Changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| python/evalio/rerun.py | Major rerun visualization overhaul with distinctipy colors and dictionary-based feature handling |
| python/evalio/datasets/botanic_garden.py | Fixed sequence name comparison bug |
| python/evalio/cli/parser.py | Added warning for unused pipeline parameters |
| python/evalio/cli/dataset_manager.py | Enhanced dataset removal to handle directories |
| pyproject.toml | Added distinctipy dependency |
| docs/quickstart.md | Updated rerun API calls |
| docs/examples/data_loading.md | Updated rerun API calls |
| cpp/evalio/pipeline.h | Updated interface to return feature dictionaries |
| cpp/evalio/macros.h | New macro system for parameter handling |
| cpp/bindings/pipelines/loam.h | Converted to use new macro system |
| cpp/bindings/pipelines/lio_sam.h | Converted to use new macro system |
| cpp/bindings/pipelines/kiss_icp.h | Converted to use new macro system |
| cpp/bindings/pipeline.h | Updated bindings for new interface |
| README.md | Updated rerun API calls |
| .clang-format | Changed escape newline alignment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes a handful of upgrades to the pipeline class. This will make some breaking changes, but I don't think we have many users yet, so now is the time! Specifically,
add_lidarandmapboth now return dictionaries of points to enable visualizing the different features found in the pipeline.distinctipyto ensure we are utilizing distinct colors in rerun. No more similar colors! 🎉EVALIO_PARSE_PARAMSmacro that automatically implements bothdefault_paramsandset_params. This should help ensure there isn't any discrepancy between the two functions and remove probably the most tedious part of writing a pipeline wrapper.I think that's about it. More to come!