Skip to content

pipeline/genz#43

Merged
contagon merged 6 commits into
masterfrom
pipeline/genz
Sep 11, 2025
Merged

pipeline/genz#43
contagon merged 6 commits into
masterfrom
pipeline/genz

Conversation

@contagon
Copy link
Copy Markdown
Owner

Add in GenZ-ICP pipeline!

@contagon contagon requested a review from Copilot September 10, 2025 21:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the GenZ-ICP pipeline to the evalio framework, extending the set of available LiDAR odometry algorithms. GenZ-ICP is an enhanced version of KissICP that includes normal estimation and a novel weighting scheme for point correspondences.

  • Adds GenZ-ICP pipeline integration with setup script, patch file, and C++ bindings
  • Includes configuration parameters and implementation for the GenZ-ICP algorithm
  • Updates build system to include GenZ-ICP as an optional pipeline

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
cpp/setup_pipelines.sh Adds GenZ-ICP repository cloning and patch application to pipeline setup
cpp/bindings/pipelines/genz_icp.patch Contains patches to modify GenZ-ICP build configuration and remove visualization code
cpp/bindings/pipelines/genz_icp.h Implements C++ wrapper class for GenZ-ICP pipeline integration
cpp/bindings/pipelines/bindings.h Adds Python bindings registration for GenZ-ICP pipeline
cpp/bindings/CMakeLists.txt Updates build system to include GenZ-ICP pipeline and removes conditional stub generation
Comments suppressed due to low confidence (1)

cpp/bindings/pipelines/genz_icp.h:1

  • Missing space after 'for' in the documentation string. Should be 'for weighting' instead of 'for weighting'.
#pragma once

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cpp/bindings/CMakeLists.txt
@contagon contagon merged commit 092882d into master Sep 11, 2025
12 checks passed
@contagon contagon deleted the pipeline/genz branch September 11, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants