pipeline/genz#43
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds the GenZ-ICP pipeline to the evalio framework, extending the set of available LiDAR odometry algorithms. GenZ-ICP is an enhanced version of KissICP that includes normal estimation and a novel weighting scheme for point correspondences.
- Adds GenZ-ICP pipeline integration with setup script, patch file, and C++ bindings
- Includes configuration parameters and implementation for the GenZ-ICP algorithm
- Updates build system to include GenZ-ICP as an optional pipeline
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| cpp/setup_pipelines.sh | Adds GenZ-ICP repository cloning and patch application to pipeline setup |
| cpp/bindings/pipelines/genz_icp.patch | Contains patches to modify GenZ-ICP build configuration and remove visualization code |
| cpp/bindings/pipelines/genz_icp.h | Implements C++ wrapper class for GenZ-ICP pipeline integration |
| cpp/bindings/pipelines/bindings.h | Adds Python bindings registration for GenZ-ICP pipeline |
| cpp/bindings/CMakeLists.txt | Updates build system to include GenZ-ICP pipeline and removes conditional stub generation |
Comments suppressed due to low confidence (1)
cpp/bindings/pipelines/genz_icp.h:1
- Missing space after 'for' in the documentation string. Should be 'for weighting' instead of 'for weighting'.
#pragma once
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add in GenZ-ICP pipeline!