Skip to content

feat(pl): Type conversions#62

Merged
contagon merged 6 commits into
mainfrom
feat/conversion
Oct 30, 2025
Merged

feat(pl): Type conversions#62
contagon merged 6 commits into
mainfrom
feat/conversion

Conversation

@contagon
Copy link
Copy Markdown
Owner

@contagon contagon commented Oct 30, 2025

There was a LOT of redundant converting between types code happening all over the codebase (oh how I miss Rust's .into()!), so all of it was moved into a new templated convert function. This should help with writing new pipelines, and makes convert containers types a lot easier.

Still todo:

  • Make sure results are still the same
  • Make vector conversion work with custom allocates (ct-icp in particular needs this)
  • Verify new convert functions make it into the python wheel

@contagon
Copy link
Copy Markdown
Owner Author

Verified results are all the same. The exception is lio-sam which I'm not getting consistent results out of which isn't terribly surprising.

@contagon contagon merged commit c629fef into main Oct 30, 2025
14 checks passed
@contagon contagon deleted the feat/conversion branch November 1, 2025 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant