-
Notifications
You must be signed in to change notification settings - Fork 49
feat: add Paket #5483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: add Paket #5483
Conversation
| @@ -0,0 +1,18 @@ | |||
| #!/bin/bash | |||
|
|
|||
| function check_tool_requirements () { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please create all in typescript instead of legacy v2 tool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I didn't copy the right example. 😅
I couldn't find any parent logic. Does it no longer exist?
When I run install-tool dotnet 10.0.100, the DOTNET_ROOT environment variable isn't exported. This is necessary to then run paket. It is correctly configured by dotnet on https://github.com/containerbase/base/blob/main/src/cli/tools/dotnet.ts#L67
What should I do to ensure that the environment variable is exported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand with extraToolEnvs. Everything should be fine now 🙂
| } | ||
|
|
||
| function install_tool () { | ||
| dotnet tool install -g paket --version "${TOOL_VERSION}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is possible to install it to a specific path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
| } | ||
|
|
||
| function link_tool () { | ||
| shell_wrapper paket "/root/.dotnet/tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is broken when it's installed as user. renovate by default runs as user, not root.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Changes
Add paket tool to new package manager (renovatebot/renovate#37287)
It depends of dotnet, and uses the dotnet tool manager to install the correct version.
Context