Implement registering for other memory notifications besides oom#154
Conversation
|
What do you think about a single method that can return |
|
@crosbymichael I agree this would be better but I didn't know if you guys wanted to keep OOMEventFD as part of the interface so I simply added the new events to it as well. In your proposal we would be getting rid of OOMEventFD and the two new ones in favor of just one method (let's call it MemoryEvent or similar) if I'm understanding correctly? |
|
I think we would need to keep
|
|
@crosbymichael Cool I'll get to work |
|
thanks! |
* Implement funcs to register for events for the other memory cgroup files that support the notification API (memory.usage_in_bytes, memory.memsw.usage_in_bytes, memory.pressure_limit). * Small typo fix in hierarchy.go. enableds -> enables Signed-off-by: Daniel Canter <dcanter@microsoft.com>
0f13a87 to
0b707e8
Compare
|
@crosbymichael PTAL |
|
LGTM |
Implement functionality to register for events on the other memory cgroup files
that support the notification API (memory.usage_in_bytes, memory.memsw.usage_in_bytes,
memory.pressure_limit).
Small typo fix in hierarchy.go. enableds -> enables
Signed-off-by: Daniel Canter dcanter@microsoft.com