Propagate OpenTelemetry traces in outgoing RPCs from plugin clients#13113
Merged
samuelkarp merged 1 commit intocontainerd:mainfrom Mar 25, 2026
Merged
Propagate OpenTelemetry traces in outgoing RPCs from plugin clients#13113samuelkarp merged 1 commit intocontainerd:mainfrom
samuelkarp merged 1 commit intocontainerd:mainfrom
Conversation
While incoming gRPC requests are already being traced via the server-side handler, outgoing RPCs to proxy plugins are missing the client-side equivalent. Adding otelgrpc.NewClientHandler() ensures trace context is successfully propagated to the plugins. Signed-off-by: Hasan Siddiqui <hasiddiqui@google.com>
samuelkarp
approved these changes
Mar 24, 2026
cpuguy83
approved these changes
Mar 24, 2026
github-project-automation
Bot
moved this from Needs Triage
to Review In Progress
in Pull Request Review
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-project-automation
Bot
moved this from Review In Progress
to Done
in Pull Request Review
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While incoming gRPC requests are already being traced via the server-side handler, outgoing RPCs to proxy plugins are missing the client-side equivalent. Adding
otelgrpc.NewClientHandler()ensures trace context is successfully propagated to the plugins.Solves #13112