Skip to content

ci: skip advisory jobs in merge queue#13404

Merged
samuelkarp merged 1 commit into
containerd:mainfrom
cpuguy83:reduce_mergequeue_ci
May 15, 2026
Merged

ci: skip advisory jobs in merge queue#13404
samuelkarp merged 1 commit into
containerd:mainfrom
cpuguy83:reduce_mergequeue_ci

Conversation

@cpuguy83
Copy link
Copy Markdown
Member

Summary

  • Skip Windows integration, Vagrant integration, and Kubernetes node e2e for merge_group events.
  • Keep those jobs running on pull_request events for advisory coverage.
  • Leave the existing aggregate required status check name unchanged.

Rationale

merge_group CI is primarily a final sanity check that queued changes still compose cleanly. These suites are expensive and have recurring flakes, so rerunning them in the merge queue wastes capacity and can delay unrelated merges.

merge_group CI is primarily a final sanity check that queued changes still compose cleanly, not a place to rerun every expensive advisory suite.

Skip Windows integration, Vagrant integration, and Kubernetes node e2e for merge_group because those jobs are costly and have recurring flakes, which wastes merge-queue capacity and delays unrelated merges.

They still run on pull_request events for advisory coverage, and the existing aggregate required status check name is unchanged.

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Copilot AI review requested due to automatic review settings May 14, 2026 17:14
@github-project-automation github-project-automation Bot moved this to Needs Triage in Pull Request Review May 14, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Skips three expensive/flaky advisory CI suites (Windows integration, Vagrant integration, Kubernetes node E2E) when the workflow runs on merge_group events, while leaving them enabled for pull_request events. The aggregate results job uses if: always() and treats only failure/cancelled as blocking, so skipped jobs will not break the required status check.

Changes:

  • Add if: github.event_name != 'merge_group' guard to integration-windows, integration-vagrant, and node-e2e jobs.
  • No change to the aggregate results required-check job or its needs list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-project-automation github-project-automation Bot moved this from Needs Triage to Review In Progress in Pull Request Review May 15, 2026
@samuelkarp samuelkarp added this pull request to the merge queue May 15, 2026
Merged via the queue into containerd:main with commit 6085e86 May 15, 2026
97 of 100 checks passed
@github-project-automation github-project-automation Bot moved this from Review In Progress to Done in Pull Request Review May 15, 2026
@cpuguy83 cpuguy83 deleted the reduce_mergequeue_ci branch May 15, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Development

Successfully merging this pull request may close these issues.

5 participants